Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

Reduce test flakiness due to resource contention and timing #1017

Open
andrewa-stripe wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Reduce test flakiness due to resource contention and timing #1017

andrewa-stripe wants to merge 7 commits into from

Conversation

@andrewa-stripe
Copy link
Contributor

@andrewa-stripe andrewa-stripe commented Dec 16, 2022

Summary

  • Increase timeouts for some tests (go has timeouts as test runner first-class which can be used when we need fast)
  • Use assert.Eventually (this would be better than the timeouts, usually, as it will enable the test to pass as soon as it can, without trading off latency OR flakiness)

Motivation

CI builds break a lot
image

Test plan

  • run tests

Rollout/monitoring/revert plan

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@arnavdugar-stripe arnavdugar-stripe arnavdugar-stripe approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewa-stripe @arnavdugar-stripe